domi/akkoma-fe
2
1
Fork 1
Code Issues 1 Pull requests 2 Packages Projects Releases Wiki Activity

Various small layouting fixes #1

Open
riedler wants to merge 13 commits from riedler/akkoma-fe:wider-columns into donotstare
pull from: riedler/akkoma-fe:wider-columns
merge into: domi:donotstare
Conversation 7 Commits 13 Files changed 8 +172 -159
riedler commented 2024-04-26 22:11:52 +02:00
First-time contributor
Copy link
  • Wide layout
  • Minimum space for empty timeline
  • Merge CW textinput and post textarea
  • Profile view: move posts/following/followers next to username and such (you'll see lol)
  • unfuck username in post form
  • set max-height for images in posts
  • fix a bug I found
  • make changes toggleable without changing the whole new layouting structure
- [x] Wide layout - [x] Minimum space for empty timeline - [x] Merge CW textinput and post textarea - [x] Profile view: move posts/following/followers next to username and such (you'll see lol) - [x] unfuck username in post form - [x] set max-height for images in posts - [x] fix [a bug I found](https://git.sakamoto.pl/domi/akkoma-fe/pulls/1#issuecomment-447) - [ ] make changes toggleable without changing the whole new layouting structure
riedler added 2 commits 2024-04-26 22:11:52 +02:00
riedler commented 2024-04-26 22:13:34 +02:00
Author
First-time contributor
Copy link

me staring at the site called donotstare:

me staring at the site called donotstare:
riedler added 3 commits 2024-04-26 23:27:24 +02:00
436a886e12 left-aligned bio text 
why the fuck was it centered in the first place?!?
riedler added 1 commit 2024-04-26 23:43:25 +02:00
riedler commented 2024-04-27 00:00:38 +02:00
Author
First-time contributor
Copy link

bit of a before/after

Name Before After
Fused subject and post body
Left-aligned bio text
Moved post/following/followers upwards
Added minimum space to empty timeline image
Wide Layout
bit of a before/after | Name | Before | After | | --- | -------- | -------- | | Fused subject and post body | ![](/attachments/7746a627-e119-42fc-8158-98dd1b0a41f5) | ![](/attachments/cbe44792-27de-4675-a651-35070eed4688) | | Left-aligned bio text | ![](/attachments/27303fb4-3e0f-4283-8fc9-3545eba85c82) | ![](/attachments/f0c1d712-a7b9-441a-95b4-f61b78c1814d) | | Moved post/following/followers upwards | ![](/attachments/2a3517f6-d92e-40a9-bfe0-594a202f9efb) | ![](/attachments/796dcf09-22a7-4270-b7ec-d1ba001f4e61) | | Added minimum space to empty timeline | ![image](/attachments/097f3d34-a238-4d74-b2c2-795016543a41) | ![](/attachments/128de7ee-a9ff-43e2-b67c-03c2f2e65cff) | | Wide Layout | ![](/attachments/88c8df6c-39a5-4c81-8783-b95d67cfaf60) | ![](/attachments/f3449d0f-ac22-49c7-9b2e-4c358c8758b3) |
image.png
38 KiB
image.png
45 KiB
image.png
40 KiB
image.png
4.9 MiB
image.png
45 KiB
image.png
290 KiB
image.png
150 KiB
image.png
69 KiB
image.png
5.1 MiB
image.png
242 KiB
riedler changed title from WIP: Various small layouting fixes to Various small layouting fixes 2024-04-27 00:04:04 +02:00
riedler commented 2024-04-27 00:13:11 +02:00
Author
First-time contributor
Copy link

hrm I really wanna remove the default outline thingies from inputs, but that'd require more time 😓 ig it's a task for future me.

hrm I really wanna remove the default outline thingies from inputs, but that'd require more time 😓 ig it's a task for future me.
riedler added 2 commits 2024-05-20 17:08:50 +02:00
riedler added 1 commit 2024-05-20 17:19:29 +02:00
riedler added 2 commits 2024-05-20 18:18:43 +02:00
3ee8a1426f made attached images max size scale with font size 
meta-comment: eliminated corner-case weirdness by replaced cursed CSS with slightly less cursed CSS
riedler commented 2024-05-20 18:21:28 +02:00
Author
First-time contributor
Copy link

fixed a lot of minor issues - pls see if ok @domi 🥺

fixed a lot of minor issues - pls see if ok @domi 🥺
riedler commented 2024-05-27 11:07:16 +02:00
Author
First-time contributor
Copy link

note: I will have to make this updated layout toggleable with minimal side-effects - #3 needs part of the layout changes to push the scrollbars to the side of the containers on firefox, since firefox seems to be hellbent on making their scrollbars fucking invisible

note: I will have to make this updated layout toggleable with minimal side-effects - #3 needs part of the layout changes to push the scrollbars to the side of the containers on firefox, since firefox seems to be hellbent on making their scrollbars fucking invisible
riedler commented 2024-06-01 20:31:58 +02:00
Author
First-time contributor
Copy link

found a bug just now

This branch Main branch
image image
image image

I'm pretty sure it's a side-effect of this line here. Will need to fix that before merging.

edit: added second possibly related bug I found

found a bug just now | This branch | Main branch | | -------- | -------- | | ![image](/attachments/1465e6e4-4078-4aec-8980-1fa68e3e63f6) | ![image](/attachments/329f7df4-859c-4882-a9a5-87821aa92d45) | | ![image](/attachments/f1fb43e3-7a9d-45a9-a070-3c127a494ca6) | ![image](/attachments/af960e78-54ea-4f32-bab1-94dc88045555) | I'm pretty sure it's a side-effect of [this line here](https://git.sakamoto.pl/riedler/akkoma-fe/src/branch/wider-columns/src/components/gallery/gallery.vue#L99). Will need to fix that before merging. edit: added second possibly related bug I found
image.png
335 KiB
image.png
265 KiB
image.png
208 KiB
image.png
232 KiB
riedler added 2 commits 2024-06-01 21:17:05 +02:00
riedler commented 2024-06-01 21:19:14 +02:00
Author
First-time contributor
Copy link

fixed the bug.

Apparently I was calculating the aspect ratio backwards, i.e. if I wanted 16:9 I was outputting 9:16 instead. That fucked a lot of shit up, even though it was a mostly invisible bug due to the max-height I introduced alongside.

fixed the bug. Apparently I was calculating the aspect ratio backwards, i.e. if I wanted 16:9 I was outputting 9:16 instead. That fucked a lot of shit up, even though it was a mostly invisible bug due to the `max-height` I introduced alongside.
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u wider-columns:riedler-wider-columns
git checkout riedler-wider-columns

Merge

Merge the changes and update on Forgejo.
git checkout donotstare
git merge --no-ff riedler-wider-columns
git checkout donotstare
git merge --ff-only riedler-wider-columns
git checkout riedler-wider-columns
git rebase donotstare
git checkout donotstare
git merge --no-ff riedler-wider-columns
git checkout donotstare
git merge --squash riedler-wider-columns
git checkout donotstare
git merge --ff-only riedler-wider-columns
git checkout donotstare
git merge riedler-wider-columns
git push origin donotstare
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: domi/akkoma-fe#1
No description provided.
Delete branch "riedler/akkoma-fe:wider-columns"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?