From b3fe81f86a91d0c4b55f48f19bef8e5dfaf70d4f Mon Sep 17 00:00:00 2001 From: Aaron Schloser Date: Fri, 18 Dec 2015 10:35:52 -0800 Subject: [PATCH 1/2] add relativePath property to error object in order to play nicely with gulp-notify --- index.js | 2 ++ test/main.js | 1 + 2 files changed, 3 insertions(+) diff --git a/index.js b/index.js index adb4c10..93a8b36 100644 --- a/index.js +++ b/index.js @@ -127,6 +127,8 @@ var gulpSass = function gulpSass(options, sync) { error.messageFormatted = message; error.message = gutil.colors.stripColor(message); + error.relativePath = relativePath; + return cb(new gutil.PluginError( PLUGIN_NAME, error )); diff --git a/test/main.js b/test/main.js index 14b6af6..0061bd1 100644 --- a/test/main.js +++ b/test/main.js @@ -379,6 +379,7 @@ describe('gulp-sass -- sync compile', function() { stream.on('error', function(err) { err.message.indexOf('property "font" must be followed by a \':\'').should.not.equal(-1); + err.relativePath.should.equal('test/scss/error.scss'); done(); }); stream.write(errorFile); From 5e8af62356728bc448ed4ffe7c300ceec25f28ee Mon Sep 17 00:00:00 2001 From: Aaron Schloser Date: Fri, 18 Dec 2015 10:38:44 -0800 Subject: [PATCH 2/2] add relativePath assertion to sync test --- test/main.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/main.js b/test/main.js index 0061bd1..02d40e0 100644 --- a/test/main.js +++ b/test/main.js @@ -148,6 +148,8 @@ describe('gulp-sass -- async compile', function() { err.message.indexOf('test/scss/error.scss').should.not.equal(-1); // Error must include line and column error occurs on err.message.indexOf('on line 2').should.not.equal(-1); + // Error must include relativePath property + err.relativePath.should.equal('test/scss/error.scss'); done(); }); stream.write(errorFile);