lnl
/
why-is-synapse
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix the thumbnails #1

New Issue
Closed
opened 2024-03-01 20:48:55 +01:00 by lnl · 3 comments
lnl commented 2024-03-01 20:48:55 +01:00
Owner

scaling always crops the thumbnails, ignoring the thumbnailing method (scale/crop), this makes client behavior much different, by stretching photos (like Element Desktop) and/or showing cropped pictures instead of just scaled versions (Element Desktop, FluffyChat)

example invalid thumbnail: https://matrix.laura.pm/_matrix/media/r0/thumbnail/laura.pm/WHyBsZRNxQiFpBBBvrEnibZu?width=800&height=600&method=scale (valid one from a working Synapse instance, for comparison: https://matrix.badat.dev/_matrix/media/r0/thumbnail/laura.pm/WHyBsZRNxQiFpBBBvrEnibZu?width=800&height=600&method=scale)

scaling always crops the thumbnails, ignoring the thumbnailing method (scale/crop), this makes client behavior much different, by stretching photos (like Element Desktop) and/or showing cropped pictures instead of just scaled versions (Element Desktop, FluffyChat) example invalid thumbnail: https://matrix.laura.pm/_matrix/media/r0/thumbnail/laura.pm/WHyBsZRNxQiFpBBBvrEnibZu?width=800&height=600&method=scale (valid one from a working Synapse instance, for comparison: https://matrix.badat.dev/_matrix/media/r0/thumbnail/laura.pm/WHyBsZRNxQiFpBBBvrEnibZu?width=800&height=600&method=scale)
lnl self-assigned this 2024-03-01 20:48:55 +01:00
lnl closed this issue 2024-03-01 20:48:55 +01:00
lnl commented 2024-03-01 20:48:55 +01:00
Poster
Owner

mentioned in commit fe4e737082

mentioned in commit fe4e737082ff20c33c92ec813e8dda558be941c9
lnl commented 2024-03-01 20:48:55 +01:00
Poster
Owner

changed the description

changed the description
lnl commented 2024-03-01 20:48:55 +01:00
Poster
Owner

assigned to @selfisekai

assigned to @selfisekai
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
lnl
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: lnl/why-is-synapse#1
There is no content yet.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?