[playwright] fix tests

This commit is contained in:
Laura Liberda 2021-01-18 22:57:17 +01:00
parent 29128c9704
commit 9224bfe84f
2 changed files with 10 additions and 4 deletions

View file

@ -22,7 +22,8 @@ class PlaywrightHelper():
cls._real_import_pw() cls._real_import_pw()
except ImportError as err: except ImportError as err:
if fatal is True: if fatal is True:
raise ExtractorError('Playwright could not be imported: %s' % err.msg, expected=True) raise ExtractorError('Playwright could not be imported: %s' % err.msg if 'msg' in err else '[no err.msg]',
expected=True)
@classmethod @classmethod
def _version(cls): def _version(cls):

View file

@ -8,6 +8,7 @@ import unittest
sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__)))) sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
from haruhi_dl.compat import compat_str from haruhi_dl.compat import compat_str
from haruhi_dl.utils import ExtractorError
from haruhi_dl.playwright import PlaywrightHelper from haruhi_dl.playwright import PlaywrightHelper
@ -23,13 +24,17 @@ class TestPlaywright(unittest.TestCase):
helper._import_pw(fatal=True) helper._import_pw(fatal=True)
self.assertIsNotNone(helper._pw) self.assertIsNotNone(helper._pw)
self.assertIsInstance(helper._pw_version, compat_str) self.assertIsInstance(helper._pw_version, compat_str)
except ImportError: except ExtractorError:
self.assertIsNone(helper._pw) self.assertIsNone(helper._pw)
self.assertIsNone(helper._pw_version) self.assertIsNone(helper._pw_version)
def test_checking_version(self): def test_checking_version(self):
version = PlaywrightHelper._version() helper = PlaywrightHelper
self.assertIsInstance(version, (compat_str, None)) version = helper._version()
if helper._pw:
self.assertIsInstance(version, compat_str)
else:
self.assertIsNone(version)
if __name__ == '__main__': if __name__ == '__main__':